Fix cppcheck warnings, typos, style issues (backport #1227) by mergify[bot] · Pull Request #1232 · gazebosim/gz-rendering

mergify · 2026-01-28T23:03:09Z

🦟 Bug fix

Fixes #

Summary

Reducing CppCheck report size, frequent warnings:
- missing override (CI-clang seems also affected by this)
- different argument name
- variable scope can be reduced
Ogre or containers in standard library most of times use size_t, better to use
Fix typos
In general tried to follow the rule from c++ core guidelines https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c128-virtual-functions-should-specify-exactly-one-of-virtual-override-or-final (but changing it in all code could make PR much bigger)
Will left comments about some specific lines
This PR contain only non-breaking changes. Will left separate comment with couple of questions

I'm running CppCheck with compile_commands.json file which generated by cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON (and manual path tweak to run scan on host), not make cppcheck

Checklist

Signed all commits for DCO
Added tests
Updated documentation (as needed)
Updated migration guide (as needed)
Consider updating Python bindings (if the library has them)
codecheck passed (See contributing)
All tests passed (See test coverage)
While waiting for a review on your PR, please help review another open pull request to support the maintainers
Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

This is an automatic backport of pull request #1227 done by Mergify.

mergify · 2026-01-28T23:03:11Z

Cherry-pick of a395a95 has failed:

On branch mergify/bp/gz-rendering8/pr-1227
Your branch is up to date with 'origin/gz-rendering8'.

You are currently cherry-picking commit a395a952.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   examples/camera_tracking/GlutWindow.cc
	modified:   examples/lidar_visual/GlutWindow.cc
	modified:   include/gz/rendering/OrbitViewController.hh
	modified:   include/gz/rendering/OrthoViewController.hh
	modified:   include/gz/rendering/base/BaseBoundingBoxCamera.hh
	modified:   include/gz/rendering/base/BaseCamera.hh
	modified:   include/gz/rendering/base/BaseDepthCamera.hh
	modified:   include/gz/rendering/base/BaseDistortionPass.hh
	modified:   include/gz/rendering/base/BaseGaussianNoisePass.hh
	modified:   include/gz/rendering/base/BaseGeometry.hh
	modified:   include/gz/rendering/base/BaseGpuRays.hh
	modified:   include/gz/rendering/base/BaseGrid.hh
	modified:   include/gz/rendering/base/BaseLight.hh
	modified:   include/gz/rendering/base/BaseLightVisual.hh
	modified:   include/gz/rendering/base/BaseMaterial.hh
	modified:   include/gz/rendering/base/BaseRenderTarget.hh
	modified:   include/gz/rendering/base/BaseText.hh
	modified:   include/gz/rendering/base/BaseThermalCamera.hh
	modified:   include/gz/rendering/base/BaseWireBox.hh
	modified:   ogre/include/gz/rendering/ogre/OgreDynamicLines.hh
	modified:   ogre/include/gz/rendering/ogre/OgreGeometry.hh
	modified:   ogre/include/gz/rendering/ogre/OgreGrid.hh
	modified:   ogre/include/gz/rendering/ogre/OgreLight.hh
	modified:   ogre/include/gz/rendering/ogre/OgreProjector.hh
	modified:   ogre/include/gz/rendering/ogre/OgreRenderEngine.hh
	modified:   ogre/src/OgreConversions.cc
	modified:   ogre/src/OgreDistortionPass.cc
	modified:   ogre/src/OgreHeightmap.cc
	modified:   ogre/src/OgreLidarVisual.cc
	modified:   ogre/src/OgreMaterial.cc
	modified:   ogre/src/OgreMesh.cc
	modified:   ogre/src/OgreMeshFactory.cc
	modified:   ogre/src/OgreProjector.cc
	modified:   ogre/src/OgreRTShaderSystem.cc
	modified:   ogre/src/OgreRayQuery.cc
	modified:   ogre/src/OgreRenderPass.cc
	modified:   ogre/src/OgreText.cc
	modified:   ogre/src/OgreVisual.cc
	modified:   ogre2/include/gz/rendering/ogre2/Ogre2GpuRays.hh
	modified:   ogre2/include/gz/rendering/ogre2/Ogre2Grid.hh
	modified:   ogre2/include/gz/rendering/ogre2/Ogre2ParticleEmitter.hh
	modified:   ogre2/include/gz/rendering/ogre2/Ogre2RenderEngine.hh
	modified:   ogre2/include/gz/rendering/ogre2/Ogre2RenderPass.hh
	modified:   ogre2/include/gz/rendering/ogre2/Ogre2RenderTargetMaterial.hh
	modified:   ogre2/include/gz/rendering/ogre2/Ogre2Sensor.hh
	modified:   ogre2/include/gz/rendering/ogre2/Ogre2WideAngleCamera.hh
	modified:   ogre2/src/Ogre2BoundingBoxCamera.cc
	modified:   ogre2/src/Ogre2BoundingBoxMaterialSwitcher.cc
	modified:   ogre2/src/Ogre2Conversions.cc
	modified:   ogre2/src/Ogre2DepthCamera.cc
	modified:   ogre2/src/Ogre2GpuRays.cc
	modified:   ogre2/src/Ogre2LensFlarePass.cc
	modified:   ogre2/src/Ogre2Marker.cc
	modified:   ogre2/src/Ogre2Material.cc
	modified:   ogre2/src/Ogre2MeshFactory.cc
	modified:   ogre2/src/Ogre2ParticleEmitter.cc
	modified:   ogre2/src/Ogre2Projector.cc
	modified:   ogre2/src/Ogre2RayQuery.cc
	modified:   ogre2/src/Ogre2RenderEngine.cc
	modified:   ogre2/src/Ogre2RenderPass.cc
	modified:   ogre2/src/Ogre2Scene.cc
	modified:   ogre2/src/Ogre2SegmentationMaterialSwitcher.cc
	modified:   ogre2/src/Ogre2WideAngleCamera.cc
	modified:   src/CameraLens.cc
	modified:   src/OrbitViewController.cc
	modified:   src/RenderEngineManager.cc
	modified:   src/TransformController.cc
	modified:   src/Utils.cc

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   ogre/src/OgreFrustumVisual.cc
	both modified:   ogre2/include/gz/rendering/ogre2/Ogre2Scene.hh

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: Ian Chen <ichen@openrobotics.org>

mergify bot requested a review from iche033 as a code owner January 28, 2026 23:03

mergify bot added the conflicts label Jan 28, 2026

mergify bot mentioned this pull request Jan 28, 2026

Fix cppcheck warnings, typos, style issues #1227

Merged

9 tasks

github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jan 28, 2026

azeey added this to Core development Jan 28, 2026

github-project-automation bot moved this to Inbox in Core development Jan 28, 2026

iche033 closed this Jan 29, 2026

iche033 force-pushed the mergify/bp/gz-rendering8/pr-1227 branch from 6571e53 to 94f5654 Compare January 29, 2026 17:43

github-project-automation bot moved this from Inbox to Done in Core development Jan 29, 2026

cherry-pick a395a95: Fix cppcheck warnings, typos, style issues #1227

47ba97a

Signed-off-by: Ian Chen <ichen@openrobotics.org>

iche033 reopened this Jan 29, 2026

github-project-automation bot moved this from Done to Inbox in Core development Jan 29, 2026

iche033 approved these changes Jan 30, 2026

View reviewed changes

github-project-automation bot moved this from Inbox to In review in Core development Jan 30, 2026

iche033 merged commit de3911f into gz-rendering8 Jan 30, 2026
11 of 12 checks passed

iche033 deleted the mergify/bp/gz-rendering8/pr-1227 branch January 30, 2026 19:47

github-project-automation bot moved this from In review to Done in Core development Jan 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix cppcheck warnings, typos, style issues (backport #1227)#1232

Fix cppcheck warnings, typos, style issues (backport #1227)#1232
iche033 merged 1 commit intogz-rendering8from
mergify/bp/gz-rendering8/pr-1227

mergify bot commented Jan 28, 2026

Uh oh!

mergify bot commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

mergify bot commented Jan 28, 2026

🦟 Bug fix

Summary

Checklist

Uh oh!

mergify bot commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant